RFR: 8311492: FontSmoothingType LCD produces wrong color when transparency is used [v3]

[Andy Goryachev]

On Fri, 9 Feb 2024 17:17:28 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java line 172:
> 
>> 170:     @AfterAll
>> 171:     public static void doTeardownOnce() {
>> 172:         Util.shutdown();
> 
> I am sorry, Kevin, you just walked into a trap carefully laid by me before.
> Util.shutdown() needs a Stage argument, otherwise it does nothing.
> Perhaps we could change the impl. to shutdown all the stages regardless instead of passing an array of them.
> 
> And, of course, there is more than one place where we do it.  Good job, me!

We can leave this code as is and fix it during the test sprint...  I'll file a bug.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484602528