RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

Andy Goryachev angorya at openjdk.org
Fri Feb 9 18:18:04 UTC 2024


On Fri, 9 Feb 2024 07:59:47 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>> 
>> Added checks for RTL orientation of nodes and  fixed the issue in `getHitInfo()` to calculate correct hit test values.
>> 
>> Added system tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Looks good now.
Thank you for the hard work!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1323#pullrequestreview-1872960155


More information about the openjfx-dev mailing list