RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v12]

[John Hendrikx]

On Fri, 9 Feb 2024 17:48:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add some clarifying documentation
>>  - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line 414:
> 
>> 412:             12.0f, 4.001953f
>> 413:         ));
>> 414: 
> 
> should we add tests for leading/trailing tabs and milti-line strings, and multi-line with leading/trailing spaces?

Multi line strings are I think addressed in the `hard wrap` cases (they contain line breaks).  I can add a case for leading space (I only have one for trailing space), and can add cases for tabs (although there is uncertainty on how they should be treated).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1236#discussion_r1484834811