RFR: 8311492: FontSmoothingType LCD produces wrong color when transparency is used [v3]

Kevin Rushforth kcr at openjdk.org
Fri Feb 9 22:07:13 UTC 2024


On Fri, 9 Feb 2024 19:19:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> It's not really a headless vs headful distinction (the system tests are all headful). It's just that some tests have a global (static) Stage that should be hidden at shutdown time. Others, like the test in this PR, create, hide, and show a Stage in each test instance. Both are valid use cases.
>
> here it's under @AfterAll, not after each test.
> 
> But still, what's the point of hiding the stage(s) if we follow it with Platform.exit() ?
> Then we should get rid of the stage(s) argument and simply hide all the current stages, regardless.

For this test, the call to shutdown is in an `@AfterAll` method. The call to `Stage.hide` is in an `@AfterEach` method.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484845747


More information about the openjfx-dev mailing list