RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v5]

Marius Hanl mhanl at openjdk.org
Tue Feb 13 20:50:05 UTC 2024


On Sat, 10 Feb 2024 17:53:27 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> The SimpleSelector and CompoundSelector classes are public classes in an exported package, javafx.css, but they are not intended to be used by applications. They are implementation details. They cannot be constructed directly and no other JavaFX API accepts or returns a SimpleSelector or CompoundSelector.
>> 
>> We should deprecate them for removal so we can move them to a non-exported package, removing them from the public API.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use getStyleClassNames

Looks good and reasonable to me as well. 
I can also confirm that I have never used both `Selector` classes or seen any use for them.

Also +1 for `getStyleClassNames`, feels the most natural to me.

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1340#pullrequestreview-1878881707


More information about the openjfx-dev mailing list