RFR: JDK-8325798: Spinner throws uncatchable exception on tab out from garbled text

Andy Goryachev angorya at openjdk.org
Tue Feb 13 21:43:03 UTC 2024


On Tue, 13 Feb 2024 20:42:08 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> When a `Spinner` is configured with e.g. Integers (`IntegerSpinnerValueFactory`) and the user types in a `String`, e.g. 'abc' and focuses another `Node`, an exception is thrown (`NumberFormatException`).
> This exception is literally uncatchable, as it happens on focus lost.
> 
> The issue is the same as for the `DatePicker` component described in [JDK-8303478](https://bugs.openjdk.org/browse/JDK-8303478), which was fixed in PR: https://github.com/openjdk/jfx/pull/1274.
> 
> I did the exact same fix in this PR. Also added the same test.

looks good.  thank you for referring to the other bug!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1365#pullrequestreview-1878983533


More information about the openjfx-dev mailing list