RFR: JDK-8325798: Spinner throws uncatchable exception on tab out from garbled text

[Marius Hanl]

On Tue, 13 Feb 2024 22:44:50 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> When a `Spinner` is configured with e.g. Integers (`IntegerSpinnerValueFactory`) and the user types in a `String`, e.g. 'abc' and focuses another `Node`, an exception is thrown (`NumberFormatException`).
>> This exception is literally uncatchable, as it happens on focus lost.
>> 
>> The issue is the same as for the `DatePicker` component described in [JDK-8303478](https://bugs.openjdk.org/browse/JDK-8303478), which was fixed in PR: https://github.com/openjdk/jfx/pull/1274.
>> 
>> I did the exact same fix in this PR. Also added the same test.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/SpinnerTest.java line 1609:
> 
>> 1607:         spinner.getEditor().setText("2abc");
>> 1608: 
>> 1609:         // loosing focus triggers cancelEdit() because the text cannot be parsed
> 
> typo: losing

Thanks, I didn't know until today that `loose` and `lose` are actually different words in a way.🙂
I think I will still integrate it to avoid a new review cycle and given that I copied this test.
But good to know for the future!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1365#discussion_r1490732581