RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

Andy Goryachev angorya at openjdk.org
Thu Feb 15 17:29:10 UTC 2024


> Move caret animation handling due to keyboard input to the Skin, by registering a listener on the caretPosition property.  This will restart animation only when the caret position changes instead of every key press.
> 
> This also simplifies internal behaviors of TextArea, TextField, and PasswordField in light of the future InputMap RFE [JDK-8314968](https://bugs.openjdk.org/browse/JDK-8314968)

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - review comments
 - Merge remote-tracking branch 'origin/master' into 8322748.blink
 - Merge remote-tracking branch 'origin/master' into 8322748.blink
 - 8322748: Caret blinking in JavaFX should only stop when caret moves

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1368/files
  - new: https://git.openjdk.org/jfx/pull/1368/files/f04cd069..558ab28e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1368&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1368&range=00-01

  Stats: 79 lines in 7 files changed: 74 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jfx/pull/1368.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1368/head:pull/1368

PR: https://git.openjdk.org/jfx/pull/1368


More information about the openjfx-dev mailing list