RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Feb 19 00:37:59 UTC 2024


On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and fixes the dragging issue on Wayland.
>
> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add compile-time checks to GdkSeat

A shot in the dark since I don't own a touch enabled monitor:

Test 1:

 Add `GDK_SCROLL_MASK` on the original `gdk_pointer_grab` function;

Test 2:

This PR uses `GDK_SEAT_CAPABILITY_ALL_POINTING` which includes the touch masks.

So the equivalent would include `GDK_TOUCH_MASK` on `gdk_pointer_grab`.


I would bet on option 2.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1305#issuecomment-1951510764


More information about the openjfx-dev mailing list