RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]
Karthik P K
kpk at openjdk.org
Mon Feb 19 13:13:02 UTC 2024
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Move caret animation handling due to keyboard input to the Skin, by registering a listener on the caretPosition property. This will restart animation only when the caret position changes instead of every key press.
>>
>> This also simplifies internal behaviors of TextArea, TextField, and PasswordField in light of the future InputMap RFE [JDK-8314968](https://bugs.openjdk.org/browse/JDK-8314968)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - review comments
> - Merge remote-tracking branch 'origin/master' into 8322748.blink
> - Merge remote-tracking branch 'origin/master' into 8322748.blink
> - 8322748: Caret blinking in JavaFX should only stop when caret moves
LGTM
-------------
Marked as reviewed by kpk (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1368#pullrequestreview-1888384026
More information about the openjfx-dev
mailing list