RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]
Karthik P K
kpk at openjdk.org
Wed Feb 21 10:01:37 UTC 2024
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in `getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
- Merge branch 'master' into rtl_hittest_issue
- Code refactoring
- Review comments
- Fix emoji issue
- Inline node issue fix
- Code review changes
- Fix issue with multiline text
- Fix issue with RTL text within LTR text
- Review changes
- Fix multiline text insertion index calculation issue
- ... and 3 more: https://git.openjdk.org/jfx/compare/96c496a0...e3812732
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1323/files
- new: https://git.openjdk.org/jfx/pull/1323/files/72287851..e3812732
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=12
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=11-12
Stats: 294814 lines in 6614 files changed: 173890 ins; 83927 del; 36997 mod
Patch: https://git.openjdk.org/jfx/pull/1323.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1323/head:pull/1323
PR: https://git.openjdk.org/jfx/pull/1323
More information about the openjfx-dev
mailing list