Integrated: 8278021: Fix warnings in macOS glass native code and treat warnings as errors

[Martin Fox]

On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox <mfox at openjdk.org> wrote:

> Turning on warnings-as-errors for the macOS glass native code. Deprecated declarations are excluded and still appear as warnings.
> 
> In the code that tries to locate the application's dock icon there were three instances where `NO` was being passed into a method that required a pointer to a `BOOL`, not a `BOOL`. I suspect the intent was to check that the path pointed to an existing file but not a directory. Since JavaFX has gone this long without screening out directories correctly I decided not to fix that behavior except at the very end.
> 
> The only other changes of note are sending some NSNotification objects to delegate API's that require them even though we know they're ignored on the other side. It was the easiest way to get rid of the warning.

This pull request has now been integrated.

Changeset: e0b88bc7
Author:    Martin Fox <mfox at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/e0b88bc7cfede46afe28cbb4a2e333df933b5100
Stats:     59 lines in 17 files changed: 39 ins; 5 del; 15 mod

8278021: Fix warnings in macOS glass native code and treat warnings as errors

Reviewed-by: kcr, aghaisas

-------------

PR: https://git.openjdk.org/jfx/pull/687