RFR: 8314147: Updated the PhongMaterial documentation [v2]

Nir Lisker nlisker at openjdk.org
Thu Feb 22 22:23:59 UTC 2024


On Thu, 22 Feb 2024 22:18:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java line 848:
> 
>> 846:                 + ", specularPower=" + getSpecularPower() + ", diffuseMap=" + getDiffuseMap() + ", specularMap="
>> 847:                 + getSpecularMap() + ", bumpMap=" + getBumpMap() + ", selfIlluminationMap=" + getSelfIlluminationMap()
>> 848:                 + "]";
> 
> could we restore the formatting please?
> also, the first `+` is unnecessary

Weird, I specifically reverted the auto-formatting, not sure how it got in. Will revert.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1378#discussion_r1500007027


More information about the openjfx-dev mailing list