RFR: 8314147: Updated the PhongMaterial documentation [v3]
Nir Lisker
nlisker at openjdk.org
Thu Feb 22 22:46:58 UTC 2024
On Thu, 22 Feb 2024 22:20:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java line 848:
>>
>>> 846: + ", specularPower=" + getSpecularPower() + ", diffuseMap=" + getDiffuseMap() + ", specularMap="
>>> 847: + getSpecularMap() + ", bumpMap=" + getBumpMap() + ", selfIlluminationMap=" + getSelfIlluminationMap()
>>> 848: + "]";
>>
>> could we restore the formatting please?
>> also, the first `+` is unnecessary
>
> Weird, I specifically reverted the auto-formatting, not sure how it got in. Will revert.
> also, the first `+` is unnecessary
I think it was done for uniformity with the other properties. I would use a `StringJoiner` these days for such a task anyway.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1378#discussion_r1500028809
More information about the openjfx-dev
mailing list