RFR: 8314147: Updated the PhongMaterial documentation [v3]

Andy Goryachev angorya at openjdk.org
Thu Feb 22 22:54:57 UTC 2024


On Thu, 22 Feb 2024 22:44:05 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Weird, I specifically reverted the auto-formatting, not sure how it got in. Will revert.
>
>> also, the first `+` is unnecessary
> 
> I think it was done for uniformity with the other properties. I would use a `StringJoiner` these days for such a task anyway.

StringJoiner seems to provide little benefit for maps or key=value pairs.  Do you know of an alternative?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1378#discussion_r1500032969


More information about the openjfx-dev mailing list