RFR: 8314147: Updated the PhongMaterial documentation [v3]

Nir Lisker nlisker at openjdk.org
Thu Feb 22 23:16:58 UTC 2024


On Thu, 22 Feb 2024 23:07:21 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Perhaps the contribution guidelines should mention what resources can be included. In all other open source projects I worked on it was enough that the resource wasn't licensed (or had something like https://en.wikipedia.org/wiki/WTFPL).
>
> The only thing I can point at is the OCA (which is linked in the CONTRIBUTOR guidelines), which states that contributions need to be an original work.
> 
> So to double-check: Aside from that image (and the ones derived from it), are all the others your original work?

Yes, I created the textures in a generator, the schematics I drew myself, and the screenshots are from the 3D Lighting app.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1378#discussion_r1500052213


More information about the openjfx-dev mailing list