RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v3]
Michael Strauß
mstrauss at openjdk.org
Fri Feb 23 22:02:16 UTC 2024
On Fri, 23 Feb 2024 20:14:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java line 483:
>
>> 481:
>> 482: if (!AWT_SYSTEM_APPEARANCE.equals(awtAppearanceProperty)) {
>> 483: Logging.getJavaFXLogger().warning(String.format(
>
> Minor: Maybe add newlines to break this message into two or three separate lines?
Done. I've also moved the `checkSystemAppearance` assignment out of the if branch (it should be unconditionally set to `false` after the first call).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1367#discussion_r1501215285
More information about the openjfx-dev
mailing list