RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

Kevin Rushforth kcr at openjdk.org
Fri Feb 23 23:42:04 UTC 2024


On Fri, 23 Feb 2024 22:32:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> `@return` statements usually state this condition explicitly, like `Map#get`: "the value to which the specified key is mapped, or `null` if this map contains no mapping for the key".
>
> My point is that it should be mentioned in the first paragraph then.  It can be repeated in @return later, if you prefer.  Map.get() does indeed mention this in the first paragraph:
> 
> ![Screenshot 2024-02-23 at 14 30 02](https://github.com/openjdk/jfx/assets/107069028/977a6dbc-c0b0-4a00-a14d-8ff40353c365)

Given that the changes are so far limited to spelling and formatting (code style for null), I think it would be fine to limit the changes in this PR to what he has already done.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1379#discussion_r1501267342


More information about the openjfx-dev mailing list