RFR: JDK-8322964 Optimize performance of CSS selector matching [v4]

John Hendrikx jhendrikx at openjdk.org
Sun Feb 25 21:58:11 UTC 2024


On Mon, 15 Jan 2024 20:48:54 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> @mstr2 I've created #1333 to show how it would look when we move `SimpleSelector` and `CompoundSelector` to internal packages.  I think that should alleviate most concerns, and we can either integrate this first with a new public method, which will later be internal anyway, or integrate the other change first.
>
> Thanks for the detailed explanation. I agree that moving `SimpleSelector` and `CompoundSelector` to an internal package would be the best choice, and would also make the question of new API a non-issue.

A new method `getStyleClassNames` was now added as part of #1340 -- we can use that now for the optimization.  Eventually, the `SimpleSelector` and `CompoundSelector` classes will move to internal packages (probably in JFX 24) via #1333

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1501905042


More information about the openjfx-dev mailing list