RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v16]
Karthik P K
kpk at openjdk.org
Thu Feb 29 05:38:05 UTC 2024
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in `getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Review comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1323/files
- new: https://git.openjdk.org/jfx/pull/1323/files/1376441b..130587c9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=15
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=14-15
Stats: 19 lines in 3 files changed: 8 ins; 6 del; 5 mod
Patch: https://git.openjdk.org/jfx/pull/1323.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1323/head:pull/1323
PR: https://git.openjdk.org/jfx/pull/1323
More information about the openjfx-dev
mailing list