RFR: 8324233: Update JPEG Image Decoding Software to 9f [v2]
Ambarish Rapte
arapte at openjdk.org
Thu Feb 29 08:29:53 UTC 2024
On Wed, 28 Feb 2024 05:19:06 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all platforms.
>>
>> Also while updating to 9f noticed that many files don't have latest copyright year and comments from previous version updates like 9e, so updated that part also to match 9f version.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>
> Update
Looks good, just a minor query.
modules/javafx.graphics/src/main/native-iio/libjpeg/UPDATING.txt line 12:
> 10: 3) OpenJFX imports only the JPEG library source with some exceptions.
> 11: OpenJFX does not need any other applications or tools provided by IJG libjpeg.
> 12: Copy only the same 49 .c and 9 .h files as are already there.
I could see only _41_ _.c_ files in this directory: `modules/javafx.graphics/src/main/native-iio/libjpeg`
Could you please recheck.
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1372#pullrequestreview-1908052543
PR Review Comment: https://git.openjdk.org/jfx/pull/1372#discussion_r1507068044
More information about the openjfx-dev
mailing list