RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v16]
Andy Goryachev
angorya at openjdk.org
Thu Feb 29 15:52:54 UTC 2024
On Thu, 29 Feb 2024 05:38:05 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of nodes and fixed the issue in `getHitInfo()` to calculate correct hit test values.
>>
>> Added system tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments
> FontHelper.getNativeFont(
perhaps we could pick a suitable font based on the platform? to make sure we always get a valid font?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1971428499
More information about the openjfx-dev
mailing list