RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations [v2]

Andy Goryachev angorya at openjdk.org
Thu Feb 29 19:34:54 UTC 2024


On Wed, 14 Feb 2024 20:53:46 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java line 421:
>> 
>>> 419:             if (oldIndex == newIndex) {
>>> 420:                 if (!isItemChanged(oldValue, newValue)) {
>>> 421:                     // RT-37054:  we break out of the if/else code here and
>> 
>> could we also add (or replace?) the new reference for RT-37054: JDK-8096969
>
> same as the other comment, I would prefer to do that for all cell implementations in one go. If that is okay for you as well. :)

okay

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1360#discussion_r1508074943


More information about the openjfx-dev mailing list