RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v10]

Andy Goryachev angorya at openjdk.org
Thu Feb 29 19:44:19 UTC 2024


> Modified the resize algorithm to work well with fractional scale, thanks for deeper understanding of the problem thanks to  @hjohn and @mstr2 .
> 
> It is important to note that even though the constraints are given by the user in unsnapped coordinates, they are converted to snapped values, since the snapped values correspond to the actual pixels on the display.  This means the tests that validate honoring constraints should, in all the cases where (scale != 1.0), assume possibly error not exceeding (1.0 / scale) (I think).

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - Merge branch 'master' into 8299753.resize
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - tolerance
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - undo merge
 - no new api
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - cleanup
 - ... and 19 more: https://git.openjdk.org/jfx/compare/ef8e9cc5...48a1bb5d

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1156/files
  - new: https://git.openjdk.org/jfx/pull/1156/files/9105b009..48a1bb5d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=09
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=08-09

  Stats: 4044 lines in 272 files changed: 2669 ins; 474 del; 901 mod
  Patch: https://git.openjdk.org/jfx/pull/1156.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1156/head:pull/1156

PR: https://git.openjdk.org/jfx/pull/1156


More information about the openjfx-dev mailing list