RFR: 8189282: JavaFX: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows [v6]

Kevin Rushforth kcr at openjdk.org
Sat Jan 6 15:12:34 UTC 2024


On Fri, 5 Jan 2024 01:22:59 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> When reporting input method candidate position the code in GlassViewEventHandler is not applying the platform scale factors. This is causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>> 
>> This PR a no-op on Mac since the platform scale factors are always 1.0. I don't think it affects the current Linux XIM code at all but XIM is so out-of-date it has become difficult to test. PR #1080 will replace the old XIM code and needs this fix to work properly on hi-dpi screens.
>
> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed superfluous import

Looks good. I tested it on a dual-screen system with different screen scales and it all works as expected.

@arapte Can you be the second reviewer?

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1311#pullrequestreview-1807484278
PR Comment: https://git.openjdk.org/jfx/pull/1311#issuecomment-1879724220


More information about the openjfx-dev mailing list