RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c

[Kevin Rushforth]

On Fri, 5 Jan 2024 17:01:25 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> 8323077: C type error (incompatible function pointer) in X11GLContext.c

Looks good. In looking at the logs from the GHA run I can see that the warning is gone.  

I note that there is an additional warning on that same line:


2024-01-05T23:04:38.0399339Z /home/runner/work/jfx/jfx/jfx/modules/javafx.graphics/src/main/native-prism-es2/x11/X11GLContext.c:278:61: warning: pointer targets in passing argument 1 of ‘glXGetProcAddress’ differ in signedness [-Wpointer-sign]
2024-01-05T23:04:38.0403438Z   278 |             ctxInfo->glXSwapIntervalSGI = glXGetProcAddress("glXSwapIntervalSGI");
2024-01-05T23:04:38.0404485Z Successfully started process 'command 'gcc''
2024-01-05T23:04:38.0406410Z       |                                                             ^~~~~~~~~~~~~~~~~~~~


As long as you are fixing one of the warnings, it would be helpful to fix the other.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1319#pullrequestreview-1807506661