RFR: JDK-8322964 Optimize performance of CSS selector matching [v2]
Andy Goryachev
angorya at openjdk.org
Mon Jan 8 19:26:34 UTC 2024
On Mon, 8 Jan 2024 19:15:31 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> these lines discard about 4.5 bits of information on each step, surely that will affect performance, no?
>
> I am confused, and maybe I am missing something. As far as I know, this method is not called anywhere. I put a breakpoint in it. JavaFX does not use this method anywhere, nor are Selectors ever used as keys in Sets or Maps.
>
> What am I missing?
you are right, this code does not affect performance (I could not hit a break point here either).
still, since you are touching these lines, why not do it right?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1445228209
More information about the openjfx-dev
mailing list