MacOS windowDidBecomeKey inconsistency

[Johan Vos]

I should add that the inconsistency only happens when running the
systemtests using Gradle.
When I isolate the failing systemtest and run it as a Java process, it
correctly fails on both M2 and Mac/Intel.

At this point, I don't have enough information to create a JBS issue
though. I added debug info in the native code where the windowDidBecomeKey
is received, but the Gradle output shows that debug even before it outputs
that the test is starting.

- Johan

On Thu, Jan 11, 2024 at 9:08 AM Johan Vos <johan.vos at gluonhq.com> wrote:

> Hi Martin,
>
> Thanks for testing this. Just to make sure: the fact that the
> systemtest pass, is the problem. It shouldn't pass. The change in PR 1283
> caused regression that I didn't notice on the M2, but I heard the test
> correctly fails on M1, and I could confirm it correctly fails on Mac/Intel
> as well.
> Now that I know that this is not just my local M2 setup, I can have a look
> at the cause -- thanks for your useful feedback!
>
> - Johan
>
>
> On Wed, Jan 10, 2024 at 7:58 PM Martin Fox <m_r_fox at sbcglobal.net> wrote:
>
>> Johan,
>>
>> Are you referring to PR 1283? And are you seeing test failures on Intel
>> or M2?
>>
>> I just grabbed PR 1283 and the system test works fine on my M2 Mac. As
>> for JDK-8089848 I recently looked into that and it was very specific to
>> changing the focus while processing windowDidResignKey (though I suppose it
>> could also happen if you changed focus while processing
>> windowDidBecomeKey). In that bug I didn’t see any cases where
>> windowDidBecomeKey wasn’t called, just cases where it was called on the
>> wrong window. I don’t see any obvious smoking guns in the SystemMenuBarTest
>> that would lead to the same condition.
>>
>> Martin
>>
>> On Jan 10, 2024, at 2:10 AM, Johan Vos <johan.vos at gluonhq.com> wrote:
>>
>> I noticed different test results when running systemtests on a mac/intel
>> versus an M2.
>> when running systemtests from a command line using
>>
>> `sh gradlew --info -PFULL_TEST=true  :systemTests:cleanTest
>> :systemTests:test --tests=test.com.sun.javafx.tk.quantum.SystemMenuBarTest`
>>
>> I traced it down to `windowDidBecomeKey` on `GlassWindow+Overrides.m` not
>> being called on the M2. That of course leads to different paths, hence
>> different test results.
>>
>> I wonder if this is somehow related to
>> https://bugs.openjdk.org/browse/JDK-8089848. Before looking into this,
>> is this something others observed as well?
>>
>> - Johan
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240111/9ba9b46a/attachment-0001.htm>