RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v2]

Karthik P K kpk at openjdk.org
Thu Jan 11 10:15:01 UTC 2024


> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
> 
> Added checks for RTL orientation of nodes and  fixed the issue in `getHitInfo()` to calculate correct hit test values.
> 
> Added system tests to validate the changes.

Karthik P K has updated the pull request incrementally with one additional commit since the last revision:

  Code review changes

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1323/files
  - new: https://git.openjdk.org/jfx/pull/1323/files/8d42bd37..b23e4910

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=00-01

  Stats: 115 lines in 4 files changed: 5 ins; 18 del; 92 mod
  Patch: https://git.openjdk.org/jfx/pull/1323.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1323/head:pull/1323

PR: https://git.openjdk.org/jfx/pull/1323


More information about the openjfx-dev mailing list