RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels
Marius Hanl
mhanl at openjdk.org
Thu Jan 11 12:19:31 UTC 2024
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
> As seen in the unit test of the PR, when we click on the area above/below the scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In the other cases, the assumed default cell height is used.
>
> With this PR, always the default cell height is used, to determine how much is scrolled.
> This makes the behavior more consistent.
>
> Especially from the unit-test, it's clear that with this PR the behavior is much more consistent.
>
> This is also related to the following PR: https://github.com/openjdk/jfx/pull/1194
Agree, with all the tests added, especially in this area in https://github.com/openjdk/jfx/pull/1194 and in https://github.com/openjdk/jfx/pull/1246, it is much easier for us to catch regression. I will also have a look in the next days. I also noted that I got weird scrolling behaviour once, but could never reproduce it.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1326#issuecomment-1887039217
More information about the openjfx-dev
mailing list