RFR: JDK-8323543: NPE when table items are set to null [v5]

[Andy Goryachev]

On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin <duke at openjdk.org> wrote:

>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8323543: migrates tests to junit 5

I wonder if it was a mistake to migrate to junit5 in this PR, it should have been a separate task: the scope of the change has exploded, it might cause issues with backporting, etc.

Would it be possible to separate the migration from the fix?

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 3932:

> 3930:     }
> 3931: 
> 3932:     @Disabled("Fix not yet developed for TableView")

`@Test` was placed on its own line elsewhere but not in this file?

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 5414:

> 5412:     @Test public void test_rt_40319_toRight_toBottom()          { test_rt_40319(true, true, false);   }
> 5413:     @Test public void test_rt_40319_toRight_toTop()             { test_rt_40319(true, false, false);  }
> 5414:     @Test

inconsistent formatting?

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 5784:

> 5782:         final Thread.UncaughtExceptionHandler exceptionHandler = Thread.currentThread().getUncaughtExceptionHandler();
> 5783:         Thread.currentThread().setUncaughtExceptionHandler((t, e) -> fail(
> 5784:                 "We don't expect any exceptions in this test!"));

unrelated change?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1887870661
PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1449327699
PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1449329017
PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1449329777