RFR: JDK-8323543: NPE when table items are set to null [v5]
Andy Goryachev
angorya at openjdk.org
Thu Jan 11 20:13:20 UTC 2024
On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin <duke at openjdk.org> wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8323543: migrates tests to junit 5
I think the problem is that we are trying to address two issues in one PR - the fix and migration to junit5.
It might be better to go back one commit (but keep the most recent changes on a separate branch), convert the fix to use junit4 and submit the fix in this PR.
Then, create a separate JBS ticket for junit5 migration. This way the scope of the fix is reduced to a minimum, and it can be easily backported and not cause many issues.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1887888222
More information about the openjfx-dev
mailing list