RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v2]

[Andy Goryachev]

On Thu, 11 Jan 2024 10:25:44 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> or, would it make more sense to simply pass a boolean flag instead of magic values?
>
> I changed 0 to -1 to figure out if the `getHitInfo` in `PrismTextLayout` is invoked by `Text` or `TextFlow`.
> Added comment regarding this in `com.sun.javafx.scene.tex.TextLayout`.

@karthikpandelu , the more I think about it, the less I like the idea of overloading (textRunStart and curRunStart).
what if things will change in the future?

I think it'll be much cleaner to pass a boolean forTextFlow (or forText) or some such.  we have to compute such a boolean flag anyway, why not just pass it?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1449575341