RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v2]
Karthik P K
kpk at openjdk.org
Wed Jan 17 04:58:00 UTC 2024
On Tue, 16 Jan 2024 15:42:28 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Added comment and used bit logic in the condition.
>> Do you think we should create a method in TextRun? I believe it is out of scope of this PR as it will be used in other functions as well.
>
> Yes, creating such a new method in TextRun might be out of scope for this, unless we touch all the places where the bit logic is used. Up to you, it's just a suggestion.
I would prefer not to make this change in this PR. So I will keep this as it is for now.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1454584637
More information about the openjfx-dev
mailing list