RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes

[Kevin Rushforth]

On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> The SimpleSelector and CompoundSelector classes are public classes in an exported package, javafx.css, but they are not intended to be used by applications. They are implementation details. They cannot be constructed directly and no other JavaFX API accepts or returns a SimpleSelector or CompoundSelector.
> 
> We should deprecate them for removal so we can move them to a non-exported package, removing them from the public API.

Add the `since` parameter to the Deprecation annotation, but otherwise good.

modules/javafx.graphics/src/main/java/javafx/css/CompoundSelector.java line 65:

> 63:  * @deprecated This class was exposed erroneously and will be removed in a future version
> 64:  */
> 65: @Deprecated(forRemoval = true)

You also need the `since` parameter:


    @Deprecated(since = "22", forRemoval = true)

modules/javafx.graphics/src/main/java/javafx/css/SimpleSelector.java line 54:

> 52:  * @deprecated This class was exposed erroneously and will be removed in a future version
> 53:  */
> 54: @Deprecated(forRemoval = true)

@Deprecated(since = "22", forRemoval = true)

-------------

PR Review: https://git.openjdk.org/jfx/pull/1340#pullrequestreview-1832492961
PR Review Comment: https://git.openjdk.org/jfx/pull/1340#discussion_r1458970180
PR Review Comment: https://git.openjdk.org/jfx/pull/1340#discussion_r1458970684