RFR: 8322784: JFXPanel calls InputMethodRequests on wrong thread [v2]
Kevin Rushforth
kcr at openjdk.org
Sat Jan 20 14:13:43 UTC 2024
On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox <mfox at openjdk.org> wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are processed on the JavaFX application thread instead of the AWT EventQueue thread. This PR adds the runAndWait() calls to do that.
>>
>> This would be difficult to test on Windows without a fix for [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267) so I've included the fix first proposed by @prsadhuk in PR #1169. If a developer uses the sample code provided in the JavaDoc to create and show a JFXPanel there's a good chance the JFXPanel will get focus before the scene has been set. To ensure AWT always treats the JFXPanel as an active IME client we return a stub version of the InputMethodRequests object if there's no scene. AWT will continue to ask for the InputMethodRequests and once the scene has been set the panel will return a non-stub version.
>
> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>
> Switched to local array variables
The latest code changes look good to me. I'll do some additional testing, and I'm sure Andy plans to do the same.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1337#pullrequestreview-1834680336
More information about the openjfx-dev
mailing list