Integrated: 8322784: JFXPanel calls InputMethodRequests on wrong thread
Martin Fox
mfox at openjdk.org
Tue Jan 23 21:26:40 UTC 2024
On Tue, 16 Jan 2024 17:59:42 GMT, Martin Fox <mfox at openjdk.org> wrote:
> On Windows we need to ensure InputMethodRequests coming from JFXPanel are processed on the JavaFX application thread instead of the AWT EventQueue thread. This PR adds the runAndWait() calls to do that.
>
> This would be difficult to test on Windows without a fix for [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267) so I've included the fix first proposed by @prsadhuk in PR #1169. If a developer uses the sample code provided in the JavaDoc to create and show a JFXPanel there's a good chance the JFXPanel will get focus before the scene has been set. To ensure AWT always treats the JFXPanel as an active IME client we return a stub version of the InputMethodRequests object if there's no scene. AWT will continue to ask for the InputMethodRequests and once the scene has been set the panel will return a non-stub version.
This pull request has now been integrated.
Changeset: 11706581
Author: Martin Fox <mfox at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/11706581053ca3fc38b175882e573858d0d42020
Stats: 43 lines in 2 files changed: 29 ins; 0 del; 14 mod
8322784: JFXPanel calls InputMethodRequests on wrong thread
8090267: JFXPanel Input Problem
Reviewed-by: kcr, angorya
-------------
PR: https://git.openjdk.org/jfx/pull/1337
More information about the openjfx-dev
mailing list