RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

Kevin Rushforth kcr at openjdk.org
Wed Jan 24 15:05:43 UTC 2024


On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> The SimpleSelector and CompoundSelector classes are public classes in an exported package, javafx.css, but they are not intended to be used by applications. They are implementation details. They cannot be constructed directly and no other JavaFX API accepts or returns a SimpleSelector or CompoundSelector.
>> 
>> We should deprecate them for removal so we can move them to a non-exported package, removing them from the public API.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add since parameter to deprecation annotation

Since there is now no hurry to do this, I think we should proceed as follows:

1. Target this deprecation-for-removal enhancement, including adding the needed base class methods from the two subclasses that are being deprecated, to JavaFX 23. This would be done first, as soon as we settle on the new base class methods.
2. Proceed with [JDK-8322964](https://bugs.openjdk.org/browse/JDK-8322964) / PR #1316 .
3. Later, probably in JavaFX 24, proceed with [JDK-8323706](https://bugs.openjdk.org/browse/JDK-8323706) / PR #1333 to remove SimpleSelector and CompoundSelector from the public API (by moving them to an internal package).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1908313239


More information about the openjfx-dev mailing list