RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors

[Martin Fox]

On Fri, 26 Jan 2024 18:21:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Yes, the deprecated constants should be fixed as the code is updated. They weren't included in this PR because there's a lot of them and they're all cosmetic.
>
> @beldenfox I let this PR drop off  my radar a while ago. Sorry about that!
> 
> I've been taking a look at our various warnings in a number of places, and was recently reminded of this by a comment you made in PR #1351 :
> 
>> I also updated a few deprecated constants so this file no longer generates compiler warnings.
> 
> Would you be willing to revive this PR, provided of course, that I actually review it this time? It will likely need to be updated in light of other changes in the past year or so.

@kevinrushforth I'd love to revive this PR! The keyboard related bugs are settling down so I was planning to do some cleanup of the Mac code this cycle. I'll take another look at this.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/687#issuecomment-1912737237