RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v3]

[Kevin Rushforth]

On Sat, 27 Jan 2024 15:47:44 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Added a utility method to run code on the FX thread if it's not already, and changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Call the correct super method

I think the three `playFrom*` methods need the same doc and implementation change to delegate to the FX app thread to avoid any potential problems.

I also recommend reverting the doc changes around not executing immediately (it is even more likely to be true in some cases with this change).

modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 979:

> 977:      * </code>
> 978:      * <p>
> 979:      * Note: if this method is not called on the JavaFX Application Thread, it is delegated to it automatically.

We need to leave in the note about it being asynchronous and that that that animation may not start immediately. I recommend to revert that part of the change here and elsewhere.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1352#pullrequestreview-1847109617
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1468515480