RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v3]

Kevin Rushforth kcr at openjdk.org
Sat Jan 27 17:02:32 UTC 2024


On Sat, 27 Jan 2024 16:50:18 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 979:
>> 
>>> 977:      * </code>
>>> 978:      * <p>
>>> 979:      * Note: if this method is not called on the JavaFX Application Thread, it is delegated to it automatically.
>> 
>> We need to leave in the note about it being asynchronous and that that that animation may not start immediately. I recommend to revert that part of the change here and elsewhere.
>
> The call is asynchronous (and the animation might not start immediately) only when called from a background thread, so I propose:
> 
> 
> Note: if this method is not called on the JavaFX Application Thread, it is delegated to it automatically.
> In this case, the call is asynchronous and may not happen immediately.

That seems fine.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1468533123


More information about the openjfx-dev mailing list