RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

Nir Lisker nlisker at openjdk.org
Sat Jan 27 21:59:34 UTC 2024


On Sat, 27 Jan 2024 19:43:22 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> However, I'm not sure about the method naming `OnFxThread`, as it might imply that what it does is already done on the FX thread, therefore not needing to be wrapped up by `runOnFxThread`.

I understand what you mean, but the way I see it is that they do already run on the FX thread because that's the only reason they exist. I could use something like `runMustBeOnFxThread` or `runOnlyFromFxThread` if that's better.
Note that there are already `do___` methods (bad names IMO), and adding `run___` might be confusing.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1468663135


More information about the openjfx-dev mailing list