RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]
Nir Lisker
nlisker at openjdk.org
Mon Jan 29 14:19:04 UTC 2024
On Mon, 29 Jan 2024 12:44:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Probably you won't like `xxImpl` either?
>> I'm not sure we should start adding `runMustBeOnFxThread` to every method name out there that should run on the FX thread. In this case, maybe we could simply add a small javadoc with a comment, and that's it. Neither will enforce a real check about that.
>
> I was also going to suggest `xxImpl` with a short javadoc comment. That is a pattern we use elsewhere. I don't dislike the current name, but I can see Jose's point.
Changed to `xxImpl` with a doc comment.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469655778
More information about the openjfx-dev
mailing list