RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

Nir Lisker nlisker at openjdk.org
Mon Jan 29 20:52:42 UTC 2024


On Mon, 29 Jan 2024 19:22:17 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update tests
>
> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 989:
> 
>> 987:      * This method must be run on the JavaFX Application Thread.
>> 988:      *
>> 989:      * @see #playFromStartImpl()
> 
> Do you mean `playFromStart()`?

Yes, there are copy-paste mistakes.

> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Copyright header should keep 2023, even if it is almost completely changed

Even if it wasn't released?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470191833
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470192960


More information about the openjfx-dev mailing list