RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v6]

John Hendrikx jhendrikx at openjdk.org
Tue Jan 30 00:45:41 UTC 2024


On Mon, 29 Jan 2024 16:35:05 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move test that needs QuantumToolkit to system tests
>
> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line 149:
> 
>> 147:     @Disabled
>> 148:     @Test
>> 149:     void complexTestsThatAreBrokenSince2013() {
> 
> @kevinrushforth
> re: ancient tests
> 
> this is the only skipped test - quite possibly due to wrong expectations (about Thai)
> 
> Due to relative complexity of the change, I think we need all the tests we could get in this PR

I added the ticket number in the `@Disabled`.  The ticket however is pretty useless to keep open I think.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1236#discussion_r1470427170


More information about the openjfx-dev mailing list