RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS [v3]

Jay Bhaskar jbhaskar at openjdk.org
Tue Jan 30 06:02:42 UTC 2024


On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> As noted in the JBS bug, this is a follow-on to [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered while testing the fix for [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in the IME code when using WebView in a JFXPanel on macOS).
>> 
>> I have tested this in connection with with the proposed fix for JDK-8221261, although it is a valid fix regardless.
>> 
>> This expands the fix done in [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) to call all of the WebKit methods on the right thread. Additionally, we sometimes see spurious exceptions where the committed text is coming back as null, so I changed the log level to "fine" rather than "severe" for those exceptions. I'll file a follow-up bug  to see if any of these are real problems or not.
>
> Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Revert change to log message when exception occurs
>  - Merge branch 'master' into 8322703-webkit-ime-crash
>  - Merge remote-tracking branch 'upstream/master' into 8322703-webkit-ime-crash
>  - 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

+ looks good to me, tested on my machine

-------------

Marked as reviewed by jbhaskar (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1321#pullrequestreview-1850284081


More information about the openjfx-dev mailing list