Platform preferences theme detection

[Christopher Schnick]

Hello Nir,

I'm not entirely familiar with every ea build, but I'm under the 
impression that the last available 22+ea maven release, which is now 
almost 3 months old, does not contain the platform preferences API and 
also does not contain the kinda important css performance regression fixes.

On 1/30/2024 1:33 PM, Nir Lisker wrote:
> Hi Christopher,
>
> Looking at Maven Central, 
> https://mvnrepository.com/artifact/org.openjfx/javafx, JavaFX releases 
> ea builds there, which I sometimes use myself from Maven/Gradle. 
> Version 21 had 6 ea versions, and 22 has 3. The release cycle is 6 
> months per final version (aligned with OpenJDK).
>
> - Nir
>
> On Tue, Jan 30, 2024 at 2:18 PM Christopher Schnick 
> <crschnick at xpipe.io> wrote:
>
>     Alright I will try out the new ea release once the fix is
>     integrated. Other than that, everything works fine for me so far
>     with observing colors using the platform-specific strings.
>
>     As a side note, I think the community would have caught this issue
>     earlier if there were more frequent maven releases of ea builds.
>     As of right now, the only way to properly use recent ea features
>     is downloading the jars and jmods manually from the jdk.java.net
>     <http://jdk.java.net> site, which is cumbersome. I don't know how
>     much of the maven release pipeline is automated and how much work
>     more frequent ea releases would be, but it would definitely help
>     with early testing and adoption.
>
>     On 1/29/2024 11:09 PM, Michael Strauß wrote:
>>     I see that the names of the platform mappings defined in
>>     WinApplication::getPlatformKeyMappings() are simply wrong
>>     ("Windows.UIColor.ForegroundColor" instead of
>>     "Windows.UIColor.Foreground"), so the platform mappings are not
>>     applied to the properties.
>>
>>     That's quite surprising, and it's a change that must have slipped
>>     into the feature at a very late stage during development, so that
>>     it went unnoticed by all reviewers.
>>     I'll file a bug and prepare a fix for this issue.
>>
>>
>>     On Mon, Jan 29, 2024 at 10:45 PM Christopher Schnick
>>     <crschnick at xpipe.io> wrote:
>>
>>         Hello Michael,
>>
>>         I took a look at the implementation and tried to find the
>>         issue. From what I can see, the mappings returned are correct:
>>
>>
>>
>>         but it seems like they are somehow not applied the
>>         PreferencesProperties:
>>
>>         Let me know whether I can help with anything to debug this issue.
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240130/39871bfa/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img1.png
Type: image/png
Size: 39755 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240130/39871bfa/img1-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img2.png
Type: image/png
Size: 36000 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240130/39871bfa/img2-0001.png>