RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]
Martin Fox
mfox at openjdk.org
Tue Jan 30 16:17:25 UTC 2024
On Mon, 29 Jan 2024 19:04:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>>
>> When IM enabled state changes we dismiss the IM window.
>
> ... and scenarios described in JDK-8088172 and JDK-8089803 seem to have been fixed.
@andy-goryachev-oracle The behavior you're seeing when clicking on another control is a manifestation of https://bugs.openjdk.org/browse/JDK-8320912. I put together a fix for that bug but decided not to roll it into this PR. If it would help testing I could do that.
The current code to disable the IME happens *after* focus has already moved to the node that doesn't want IME input. So the commit that's fired off by `unmarkText` targets the wrong node. The fix is to implement finishInputMethodComposition so we do the cleanup before the focus changes.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1351#issuecomment-1917084109
More information about the openjfx-dev
mailing list