RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

[Kevin Rushforth]

On Wed, 3 Jul 2024 14:30:45 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> eduardsdv has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'refs/remotes/origin/master' into bugfix/JDK-8322619-render-dirty-flag
>>  - JDK-8322619: Fix waiting for the stage
>>  - JDK-8322619: Improve output message in test
>>  - JDK-8322619: Avoid using of Thread.sleep(..)
>>  - JDK-8322619: Combine clearDirtyTree() and clearDirty() methods.
>
> tests/system/src/test/java/test/com/sun/prism/impl/NGNodeDirtyFlagTest.java line 68:
> 
>> 66:             root = new StackPane();
>> 67:             primaryStage.setScene(new Scene(root, 500, 400));
>> 68: 
> 
> Please add `primaryStage.setAlwaysOnTop(true);` call here, without it the test can fail fail intermittently if the test window gets behind any other window.

Also, we generally recommend an undecorated stage for any tests that do a screen capture.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1451#discussion_r1664354188