RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

eduardsdv duke at openjdk.org
Wed Jul 3 16:39:29 UTC 2024


On Mon, 1 Jul 2024 18:24:36 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> eduardsdv has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'refs/remotes/origin/master' into bugfix/JDK-8322619-render-dirty-flag
>>  - JDK-8322619: Fix waiting for the stage
>>  - JDK-8322619: Improve output message in test
>>  - JDK-8322619: Avoid using of Thread.sleep(..)
>>  - JDK-8322619: Combine clearDirtyTree() and clearDirty() methods.
>
> tests/system/src/test/java/test/com/sun/prism/impl/NGNodeDirtyFlagTest.java line 49:
> 
>> 47:     static MyApp myApp;
>> 48: 
>> 49:     private CountDownLatch latch = new CountDownLatch(1);
> 
> minor: latch is unused variable. Should be removed.

Done

> tests/system/src/test/java/test/com/sun/prism/impl/NGNodeDirtyFlagTest.java line 121:
> 
>> 119:             checkLineColor(root, lineColor.get());
>> 120:         }
>> 121: 
> 
> minor: can remove the empty line.

Done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1451#discussion_r1664465784
PR Review Comment: https://git.openjdk.org/jfx/pull/1451#discussion_r1664467869


More information about the openjfx-dev mailing list